Filter improvements in zed #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephschorr
force-pushed
the
filter-improvements
branch
4 times, most recently
from
22a9e5e
to
c5bf6cf
Compare
jzelinskie
requested changes
Feb 8, 2024
| @@ -86,3 +116,73 @@ func watchCmdFunc(cmd *cobra.Command, _ []string) error { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I can't comment on the line because it didn't change, but we should take this opportunity to update the printed format to do roughly the same format as relationships read instead of just %v:
8:00PM CREATED document:README reader user:jzelinskie
This kind of style will mirror the SpiceDB logs:
There was a problem hiding this comment.
Can you link to this output?
There was a problem hiding this comment.
Changed, but didn't add colors
| @@ -44,8 +64,18 @@ func watchCmdFunc(cmd *cobra.Command, _ []string) error { | |||
| return err | |||
| } | |||
|
|
|||
| relFilters := make([]*v1.RelationshipFilter, 0, len(watchRelationshipFilters)) | |||
There was a problem hiding this comment.
once again can't comment on the line, but the console.Errorf("starting watch stream"... , should be using the real logger and only on debug.
There was a problem hiding this comment.
Changed to printf; can't use the real logger because this code is called in WASM
josephschorr
force-pushed
the
filter-improvements
branch
from
c5bf6cf
to
7dd68a1
Compare
josephschorr
force-pushed
the
filter-improvements
branch
from
7dd68a1
to
fd4d594
Compare
josephschorr
force-pushed
the
filter-improvements
branch
from
110ad86
to
2777dc3
Compare
josephschorr
force-pushed
the
filter-improvements
branch
from
0a37a00
to
c1dca00
Compare
jzelinskie
approved these changes
Mar 14, 2024
jzelinskie
approved these changes
Mar 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates zed to support recently adding relationship filtering improvements in SpiceDB
Requires authzed/spicedb#1739